Enable prevent-volume-mode-conversion by default following k8s 1.28 release

[akalenyu]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This is beta since 1.27 so we can safely default to true, to get this new validation logic. https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3141-prevent-volume-mode-conversion/kep.yaml#L30

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Enable prevent-volume-mode-conversion feature flag by default.
ACTION REQUIRED: 
Volume mode change will be rejected when creating a PVC from a VolumeSnapshot unless the AllowVolumeModeChange annotation has been set to true. Applications relying on volume mode change when creating a PVC from VolumeSnapshot need to be updated accordingly.

[k8s-ci-robot]

Welcome @akalenyu!

It looks like this is your first PR to kubernetes-csi/external-snapshotter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-snapshotter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @akalenyu. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xing-yang]

/ok-to-test

[xing-yang]

/retest

[xing-yang]

Can you change the type of PR from "cleanup" to "feature"?

[xing-yang]

Suggest add the following in the release note:

Enable prevent-volume-mode-conversion feature flag by default.
ACTION REQUIRED: 
Volume mode change will be rejected when creating a PVC from a VolumeSnapshot unless the AllowVolumeModeChange annotation has been set to true. Applications relying on volume mode change when creating a PVC from VolumeSnapshot need to be updated accordingly.

[xing-yang]

/assign @RaunakShah

[xing-yang]

/retest

[xing-yang]

Please rebase to get around the Trivy error.

[RaunakShah]

I suppose we should say it's a beta feature now?

[akalenyu]

Changed the text. hopefully this is better 🙏

[akalenyu]

Suggest add the following in the release note:

Enable prevent-volume-mode-conversion feature flag by default.
ACTION REQUIRED: 
Volume mode change will be rejected when creating a PVC from a VolumeSnapshot unless the AllowVolumeModeChange annotation has been set to true. Applications relying on volume mode change when creating a PVC from VolumeSnapshot need to be updated accordingly.

Done, thanks!

[akalenyu]

@xing-yang @RaunakShah Should we address backup vendors explicitly somehow? I imagine these will be the target audience to observe a behavioral change

Also note I am right now keeping

external-snapshotter/deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml

Lines 40 to 42 in 895dc73

	# Add a marker to the snapshot-controller manifests. This is needed to enable feature gates in CSI prow jobs.
	# For example, in https://github.com/kubernetes-csi/csi-release-tools/pull/209, the snapshot-controller YAML is updated to add --prevent-volume-mode-conversion=true so that the feature can be enabled for certain e2e tests.
	# end snapshot controller args

[xing-yang]

/test pull-kubernetes-csi-external-snapshotter-1-26-on-kubernetes-1-26

[xing-yang]

@xing-yang @RaunakShah Should we address backup vendors explicitly somehow? I imagine these will be the target audience to observe a behavioral change

I have brought this up several times in the Data Protection WG meeting. I'll make sure this release note shows up in both external-snapshotter and external-provisioner release area, and also send an email to the DP WG mailing list after the changes are in.

[xing-yang]

/test pull-kubernetes-csi-external-snapshotter-1-26-on-kubernetes-1-26

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment