Fix the build files so that prow job can run successfully #30
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign @wlan0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brahmaroutu, wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -3,6 +3,7 @@ kind: ClusterRole | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| metadata: | |||
| name: objectstorage-controller-role | |||
| namespace: default | |||
There was a problem hiding this comment.
It's odd this needs to be added, and not expected. Could you elaborate why these were added? kustomize (or kubectl -k) should take care of these already.
| @@ -25,7 +26,8 @@ rules: | |||
| kind: ClusterRoleBinding | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| metadata: | |||
| name: system:objectstorage-controller | |||
| name: objectstorage-controller | |||
| namespace: default | |||
There was a problem hiding this comment.
A ClusterRoleBinding doesn't have a namespace.
| @@ -34,6 +36,7 @@ metadata: | |||
| subjects: | |||
| - kind: ServiceAccount | |||
| name: objectstorage-controller-sa | |||
| namespace: default | |||
There was a problem hiding this comment.
| @@ -43,6 +46,7 @@ kind: Role | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| metadata: | |||
| name: objectstorage-controller | |||
| namespace: default | |||
There was a problem hiding this comment.
| @@ -57,6 +61,7 @@ kind: RoleBinding | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| metadata: | |||
| name: objectstorage-controller | |||
| namespace: default | |||
There was a problem hiding this comment.
| @@ -65,6 +70,7 @@ metadata: | |||
| subjects: | |||
| - kind: ServiceAccount | |||
| name: objectstorage-controller-sa | |||
| namespace: default | |||
There was a problem hiding this comment.
No description provided.