Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

fix rbac rules and check for errors getting bucketclass #34

Merged
merged 1 commit into from
Jan 14, 2021
Merged

fix rbac rules and check for errors getting bucketclass #34

merged 1 commit into from
Jan 14, 2021

Conversation

wlan0
Copy link
Contributor

@wlan0 wlan0 commented Jan 13, 2021

No description provided.

@wlan0 wlan0 requested a review from brahmaroutu January 13, 2021 05:24
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2021
brahmaroutu
brahmaroutu reviewed Jan 13, 2021
View reviewed changes
Copy link
Contributor

@brahmaroutu brahmaroutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wlan0 Please gofmt the code for the unit test to pass.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2021
@brahmaroutu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 192f68c into kubernetes-retired:master Jan 14, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@brahmaroutu brahmaroutu brahmaroutu left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

@rrati rrati Awaiting requested review from rrati

Assignees

@brahmaroutu brahmaroutu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wlan0 @k8s-ci-robot @brahmaroutu