Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Added push to Cloudbuild.yaml and swapped out quay.io with gcr repo #59

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

aarongalang
Copy link
Contributor

Added a push step to the Cloudbuild.yaml file and changed references to quay.io repo in Makefile and build.make to the gcr.io repo. Does build, but I can't test if pushing works without proper permissions.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 29, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aarongalang / name: Aaron Galang (c1bd0eb)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @aarongalang!

It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/container-object-storage-interface-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @aarongalang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2022
@wlan0
Copy link
Contributor

wlan0 commented Jul 29, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2022
@xing-yang
Copy link

/assign @pohly
@pohly Can you help take a look?

@xing-yang
Copy link

@aarongalang Please sign CLA.

@pohly
Copy link
Contributor

pohly commented Aug 2, 2022

This repo seems to use csi-release-tools already. Is there a reason to not also use the cloudbuild.yaml from there?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 2, 2022
@xing-yang
Copy link

/assign

@xing-yang
Copy link

This repo seems to use csi-release-tools already. Is there a reason to not also use the cloudbuild.yaml from there?

@pohly COSI has its own release-tools here: https://github.com/kubernetes-sigs/container-object-storage-interface-spec/tree/master/release-tools

@wlan0 wlan0 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2022
@wlan0 wlan0 changed the title WIP Added push to Cloudbuild.yaml and swapped out quay.io with gcr repo Added push to Cloudbuild.yaml and swapped out quay.io with gcr repo Aug 4, 2022
@pohly
Copy link
Contributor

pohly commented Aug 4, 2022

That looks like a fork of https://github.com/kubernetes-csi/csi-release-tools? It's the exact same files.

Anyway, I don't think I can help here.

@xing-yang
Copy link

That looks like a fork of https://github.com/kubernetes-csi/csi-release-tools? It's the exact same files.
Anyway, I don't think I can help here.

@pohly Initially it was a copy from csi-release-tools, but later on they removed lots of things because of the differences between the repos.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2022
@xing-yang
Copy link

@aarongalang Can you resolve the merge conflicts?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2022
@wlan0
Copy link
Contributor

wlan0 commented Aug 8, 2022

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aarongalang, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 75a70d3 into kubernetes-retired:master Aug 8, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants