-
Notifications
You must be signed in to change notification settings - Fork 28
Added push to Cloudbuild.yaml and swapped out quay.io with gcr repo #59
Conversation
|
Welcome @aarongalang! |
Hi @aarongalang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@aarongalang Please sign CLA. |
This repo seems to use csi-release-tools already. Is there a reason to not also use the cloudbuild.yaml from there? |
/assign |
@pohly COSI has its own release-tools here: https://github.com/kubernetes-sigs/container-object-storage-interface-spec/tree/master/release-tools |
That looks like a fork of https://github.com/kubernetes-csi/csi-release-tools? It's the exact same files. Anyway, I don't think I can help here. |
@pohly Initially it was a copy from csi-release-tools, but later on they removed lots of things because of the differences between the repos. |
@aarongalang Can you resolve the merge conflicts? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aarongalang, wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added a push step to the Cloudbuild.yaml file and changed references to quay.io repo in Makefile and build.make to the gcr.io repo. Does build, but I can't test if pushing works without proper permissions.