-
Notifications
You must be signed in to change notification settings - Fork 18
move to klog, and refactoring around error handling #21
move to klog, and refactoring around error handling #21
Conversation
Hi @krishchow. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @wlan0 @sajanjswl |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krishchow, sajanjswl, wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
397b37b
to
334a1ff
Compare
334a1ff
to
c256a2b
Compare
/lgtm |
This PR removes references to glog, and starts the move to logging with klog/v2. Additionally, this starts the work on refactoring error handling so we utilize wrapping and separate logging from error creation.