Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add enableVolumeMountGroup feature flag #1236

Merged
merged 2 commits into from
May 8, 2023
Merged

feat: add enableVolumeMountGroup feature flag #1236

merged 2 commits into from
May 8, 2023

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds enableVolumeMountGroup feature flag to address #1224

Which issue(s) this PR fixes:

Fixes #1224

Requirements:

Special notes for your reviewer:

Release note:

feat: add enableVolumeMountGroup feature flag

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 4, 2023
@k8s-ci-robot k8s-ci-robot requested review from gnufied and ZeroMagic May 4, 2023 07:55
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@andyzhangx andyzhangx force-pushed the add-enableVolumeMountGroup branch from 2acfb3b to d590a9c Compare May 4, 2023 09:26
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx mentioned this pull request May 4, 2023
Closed
ZeroMagic
ZeroMagic approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@ZeroMagic ZeroMagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, ZeroMagic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a84b055 into master May 8, 2023
@andyzhangx andyzhangx deleted the add-enableVolumeMountGroup branch May 11, 2023 03:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ZeroMagic ZeroMagic ZeroMagic approved these changes

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@ZeroMagic ZeroMagic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFS support violates CSI spec
3 participants
@andyzhangx @k8s-ci-robot @ZeroMagic