Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: ensure azure cloud config could be loaded from secret #1729

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix: ensure azure cloud config could be loaded from secret #1729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/azurefile/azure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func getCloudProvider(ctx context.Context, kubeconfig, nodeID, secretName, secre

if kubeClient != nil {
klog.V(2).Infof("reading cloud config from secret %s/%s", secretNamespace, secretName)
config, err := configloader.Load[azure.Config](ctx, &configloader.K8sSecretLoaderConfig{
config, err = configloader.Load[azure.Config](ctx, &configloader.K8sSecretLoaderConfig{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know whether we have any golint check or sth. else to avoid such issue? @MartinForReal @cvvz

K8sSecretConfig: configloader.K8sSecretConfig{
SecretName: secretName,
SecretNamespace: secretNamespace,
Expand Down
Loading