fix: nfs file share created in storage account that has smb file share #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
vendor: fix vendor change
andyzhangx
force-pushed
the
nfs-account-search-fix
branch
from
1383222 to
8fe100c
Compare
k8s-ci-robot
added
size/XL
|
/retest |
1 similar comment
|
/retest |
|
/cherrypick release-1.30 |
|
@andyzhangx: new pull request created: #1746 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: nfs file share created in storage account that has smb file share
by default, this driver would search a storage account when creating a new nfs file share, while if storage account with matching sku already exists, this driver fails to match EnableHTTPSTrafficOnly property in storage account, which means there is possibility that nfs file share created in a storage account that has smb file share, finally lead to nfs file share mount permission error
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: