Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: trim slash in RemoveSmbGlobalMapping #1854

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: trim slash in RemoveSmbGlobalMapping

I0419 05:10:41.566746    5668 safe_mounter_host_process_windows.go:145] remote server path: UNC\f95c76592b2ac4bcb957ad4.file.core.windows.net\pre-provisioned-multiple-pods\, local path: c:\var\lib\kubelet\plugins\kubernetes.io\csi\file.csi.azure.com\ff618e8b87f48350191c3ebae8902d9c38e17ee1b1913422f168f2865355330c\globalmount
I0419 05:10:41.567453    5668 smb.go:110] checking file ff618e8b87f48350191c3ebae8902d9c38e17ee1b1913422f168f2865355330c
I0419 05:10:41.567529    5668 smb.go:114] skip current mount path c:\var\lib\kubelet\plugins\kubernetes.io\csi\file.csi.azure.com\ff618e8b87f48350191c3ebae8902d9c38e17ee1b1913422f168f2865355330c\globalmount
I0419 05:10:41.567560    5668 smb.go:85] begin to run RemoveSmbGlobalMapping with \\f95c76592b2ac4bcb957ad4.file.core.windows.net\pre-provisioned-multiple-pods\
I0419 05:10:41.569358    5668 util.go:76] Executing command: "C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\powershell.exe -Mta -NoProfile -Command Remove-SmbGlobalMapping -RemotePath $Env:smbremotepath -Force"
E0419 05:10:42.663584    5668 safe_mounter_host_process_windows.go:151] RemoveSmbGlobalMapping(c:\var\lib\kubelet\plugins\kubernetes.io\csi\file.csi.azure.com\ff618e8b87f48350191c3ebae8902d9c38e17ee1b1913422f168f2865355330c\globalmount) failed with UnmountSmbShare failed. output: "Remove-SmbGlobalMapping : No MSFT_SmbGlobalMapping objects found with property 'RemotePath' equal to \r\n'\\\\f95c76592b2ac4bcb957ad4.file.core.windows.net\\pre-provisioned-multiple-pods\\'.  Verify the value of the property \r\nand retry.\r\nAt line:1 char:1\r\n+ Remove-SmbGlobalMapping -RemotePath $Env:smbremotepath -Force\r\n+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n    + CategoryInfo          : ObjectNotFound: (\\\\f95c76592b2ac...-multiple-pods\\:String) [Remove-SmbGlobalMapping], Ci \r\n   mJobException\r\n    + FullyQualifiedErrorId : CmdletizationQuery_NotFound_RemotePath,Remove-SmbGlobalMapping\r\n \r\n", err: exit status 1

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: trim slash in RemoveSmbGlobalMapping

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cvvz and ZeroMagic April 19, 2024 05:47
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2024
@andyzhangx
Copy link
Member Author

/retest

3 similar comments
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess f09cb7d link true /test pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit 19eabf1 into master Apr 19, 2024
28 of 30 checks passed
@andyzhangx andyzhangx deleted the trim-remove-smb-mount-suffix branch April 19, 2024 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants