Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: negotiate smb version #631

Merged
merged 1 commit into from
Apr 29, 2021
Merged

feat: negotiate smb version #631

merged 1 commit into from
Apr 29, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Apr 28, 2021 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: negotiate smb version

  • For linux kernel from 4.13 to 4.20: end up with smb3.0 (or smb3.02)
  • For linux kernel from 5.0: end up with smb3.1.1

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: negotiate smb version

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2021
@andyzhangx andyzhangx force-pushed the smb-version-negotiate branch from 6d54649 to b30cd40 Compare April 28, 2021 14:12
@andyzhangx
feat: negotiate smb version
e3fd82d 
fix golint

fix build failure
@andyzhangx andyzhangx force-pushed the smb-version-negotiate branch from b30cd40 to e3fd82d Compare April 28, 2021 14:21
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2021
@andyzhangx andyzhangx merged commit 6d44804 into master Apr 29, 2021
@andyzhangx andyzhangx deleted the smb-version-negotiate branch April 29, 2021 14:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyzhangx @k8s-ci-robot