Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Update cloud-provider-azure lib #677

Merged

Conversation

nearora-msft
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 27, 2021
@nearora-msft nearora-msft marked this pull request as draft May 27, 2021 17:44
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2021
@nearora-msft nearora-msft force-pushed the update-cloud-provider branch from c40644b to 66814ed Compare May 27, 2021 18:03
@nearora-msft nearora-msft marked this pull request as ready for review May 27, 2021 18:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2021
@nearora-msft nearora-msft force-pushed the update-cloud-provider branch 4 times, most recently from 0523004 to 8b0cbd8 Compare May 28, 2021 22:27
@nearora-msft nearora-msft force-pushed the update-cloud-provider branch 3 times, most recently from 5bcda48 to a4ee642 Compare June 7, 2021 18:43
@nearora-msft
Copy link
Contributor Author

/retest

1 similar comment
@nearora-msft
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 7, 2021

@nearora-msft: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-azurefile-csi-driver-external-e2e 8b0cbd8 link /test pull-azurefile-csi-driver-external-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nearora-msft nearora-msft force-pushed the update-cloud-provider branch from a4ee642 to 01ae47e Compare June 7, 2021 22:29
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, nearora-msft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 780e01b into kubernetes-sigs:master Jun 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants