Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

doc: deprecate AzureStorageIdentityObjectID field #1456

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jul 6, 2024

What type of PR is this?
/kind documentation

What this PR does / why we need it:
doc: deprecate AzureStorageIdentityObjectID field

from blobfuse 2.3.0, AzureStorageIdentityObjectID relies on azure cli installed on the node, pls use
AzureStorageIdentityClientID or
AzureStorageIdentityResourceID parameter instead.

CX needed to install Azure CLI on worker nodes manually.

With this PR, ObjectID (Managed Identity Authentication) now relies on the azure cli.
Azure/azure-storage-fuse@644728f#diff-b7b39483e2bf51ebe17ba7827a1b18cbaf75b74fcfe0796ae7a2d3e667b45289R95

volumeAttributes:.
  AzureStorageAuthType: msi
  AzureStorageIdentityObjectID: XXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX

Every time CX reimages a worker node with nodeOSimage Upgrade, the Azure CLI needs to be installed manually.

To avoid having to install Azure CLI on worker nodes, user should use AzureStorageIdentityClientID or AzureStorageIdentityResourceID instead of AzureStorageIdentityObjectID

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cvvz and feiskyer July 6, 2024 03:35
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2024
@andyzhangx andyzhangx merged commit 5a0a8d1 into kubernetes-sigs:master Jul 6, 2024
12 of 14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants