Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: volume cloning between different storage account for BlobAccessTierNotSupportedForAccountType error #1517

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix: volume cloning between different storage account for BlobAccessTierNotSupportedForAccountType error #1517

merged 1 commit into from
Jul 31, 2024

Conversation

umagnus
Copy link
Contributor

@umagnus umagnus commented Jul 30, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: volume cloning between different storage account for BlobAccessTierNotSupportedForAccountType error
azcopy between different storage account has this issue:
image
referring to Azure/azure-storage-azcopy#327 to fix
Also in this issue comment: Azure/azure-storage-azcopy#327 (comment), azcopy may automatically replicate the source blob's tier info to the destination, so create blob container before azcopy instead of using azcopy to create container is more correct.
add volume cloning between different account e2e test

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @umagnus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2024
@k8s-ci-robot k8s-ci-robot requested review from andyzhangx and cvvz July 30, 2024 01:51
andyzhangx
andyzhangx reviewed Jul 30, 2024
View reviewed changes
pkg/blob/controllerserver.go Outdated
srcPath = fmt.Sprintf("https://%s.blob.%s/%s", srcAccountName, storageEndpointSuffix, srcContainerName)
default:
return nil, status.Errorf(codes.InvalidArgument, "VolumeContentSource is not recognized: %v", volContentSource)
// var srcVolumeID string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove commented code if it's not needed any more

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done for mistake

pkg/blob/controllerserver.go Outdated
return nil, err
}
// dstAzcopyAuthEnv := srcAzcopyAuthEnv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@umagnus umagnus force-pushed the fix_volume_cloning branch from 2a8934f to 436348c Compare July 30, 2024 01:57
andyzhangx
andyzhangx reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 30, 2024
@andyzhangx
Copy link
Member

/retest

@umagnus umagnus force-pushed the fix_volume_cloning branch from 436348c to c905866 Compare July 31, 2024 03:30
andyzhangx
andyzhangx reviewed Jul 31, 2024
View reviewed changes
pkg/blob/controllerserver.go Outdated
}
srcPath = fmt.Sprintf("https://%s.blob.%s/%s", srcAccountName, storageEndpointSuffix, srcContainerName)
default:
return nil, status.Errorf(codes.InvalidArgument, "VolumeContentSource is not recognized: %v", volContentSource)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need return error here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will return error in copyVolume function in L829

@umagnus umagnus force-pushed the fix_volume_cloning branch from c905866 to dc158c8 Compare July 31, 2024 06:00
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2024
@umagnus umagnus force-pushed the fix_volume_cloning branch from dc158c8 to 95c09ac Compare July 31, 2024 06:06
andyzhangx
andyzhangx approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, umagnus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@umagnus umagnus mentioned this pull request Jul 31, 2024
Closed
4 tasks
@k8s-ci-robot k8s-ci-robot merged commit 0ab3253 into kubernetes-sigs:master Jul 31, 2024
22 checks passed
@andyzhangx
Copy link
Member

/cherrypick release-1.24

@andyzhangx
Copy link
Member

/cherrypick release-1.23

@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: #1517 failed to apply on top of branch "release-1.23":

Applying: fix volume cloning and add e2e
Using index info to reconstruct a base tree...
M	pkg/blob/controllerserver.go
M	test/e2e/dynamic_provisioning_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/dynamic_provisioning_test.go
Auto-merging pkg/blob/controllerserver.go
CONFLICT (content): Merge conflict in pkg/blob/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix volume cloning and add e2e
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #1519

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 31, 2024
Merged
@umagnus umagnus mentioned this pull request Jul 31, 2024
Merged
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@cvvz cvvz Awaiting requested review from cvvz

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umagnus @k8s-ci-robot @andyzhangx @k8s-infra-cherrypick-robot