-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
🌱 Bump CAPI to v1.9.z #5209
🌱 Bump CAPI to v1.9.z #5209
Conversation
/hold |
/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e |
/retest |
We are hitting #5139 with this, as we are now using the 1.30+ k8s version in testing. |
/test pull-cluster-api-provider-aws-e2e-eks pull-cluster-api-provider-aws-e2e |
/unhold |
@damdo - would you be able to squash your commits? |
@richardcase done, I left the 3 most relevant atomic commits there. Squashed the rest. |
Also /assign @nrb |
@damdo The top line of the description says this is blocked by an open issue - is that still true? |
@nrb not anymore as we moved to use NLBs in testing |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @damdo .
Just 1 nit, normally i would say to ignore it but as it will be in the CRD it might be worth correcting. wdyt?
…ion for CAPI's MachineSetPreflightCheck In the latest version, CAPI has turned on by default the MachineSetPreflightCheck feature, which now enforces the managed ControPlane object spec and status to have a new Version field (more details on the API change https://cluster-api.sigs.k8s.io/developer/providers/contracts/control-plane#controlplane-version). See: kubernetes-sigs#5225 Also more conversation details with the core CAPI maintainers: https://kubernetes.slack.com/archives/CD6U2V71N/p1739783013734149
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nrb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind support
What this PR does / why we need it:
CAPI v1.9.z is out now, so this PRs bumps the CAPI version used by CAPA with the new released one.
Bumps CAPI to v1.9.x based on https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.8-to-v1.9.md
Fixes #5335