Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump mockgen to v1.5.0 #1187

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Conversation

Evalle
Copy link
Contributor

@Evalle Evalle commented Feb 20, 2021

What type of PR is this?
/kind other

kind testing ?

What this PR does / why we need it:
Bumps mockgen to v1.5.0

Which issue(s) this PR fixes
Fixes #1185

NONE

@k8s-ci-robot
Copy link
Contributor

@Evalle: The label(s) kind/other cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind other

kind testing ?

What this PR does / why we need it:
Bumps mockgen to v1.5.0

Which issue(s) this PR fixes
Fixes #1185

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Evalle. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 20, 2021
@nader-ziada
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2021
@nader-ziada
Copy link
Contributor

@Evalle you have to run the generate and include the generated files in this PR to make the verify job pass

@CecileRobertMichon
Copy link
Contributor

since we're bumping the mock generation version, expect some diff in the mock files. Hopefully nothing that makes our tests fail...

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2021
@Evalle
Copy link
Contributor Author

Evalle commented Feb 23, 2021

@CecileRobertMichon @nader-ziada thanks for pointing it out, I've add the generated files to this PR, let's see.

@devigned
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e-windows

@nader-ziada
Copy link
Contributor

I think you will have to rebase on top of #1186 to get windows_e2e test passing

@CecileRobertMichon
Copy link
Contributor

/retest

These look like different errors

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@CecileRobertMichon
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 743055f into kubernetes-sigs:master Feb 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone Feb 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump mockgen to v1.5.0
5 participants