-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bump mockgen to v1.5.0 #1187
Bump mockgen to v1.5.0 #1187
Conversation
@Evalle: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @Evalle. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@Evalle you have to run the generate and include the generated files in this PR to make the |
since we're bumping the mock generation version, expect some diff in the mock files. Hopefully nothing that makes our tests fail... |
@CecileRobertMichon @nader-ziada thanks for pointing it out, I've add the generated files to this PR, let's see. |
/test pull-cluster-api-provider-azure-e2e-windows |
I think you will have to rebase on top of #1186 to get windows_e2e test passing |
/retest These look like different errors |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind other
kind testing ?
What this PR does / why we need it:
Bumps mockgen to v1.5.0
Which issue(s) this PR fixes
Fixes #1185