Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mutability of KubeadmConfigSpec #3195

Closed
Arvinderpal opened this issue Jun 15, 2020 · 5 comments
Closed

Mutability of KubeadmConfigSpec #3195

Arvinderpal opened this issue Jun 15, 2020 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Arvinderpal
Copy link
Contributor

User Story

  • As a user/operator I would like to have finer control over the kubeadm specific configuration parameters of my cluster.

  • As a user/operator I would like to upgrade my clusters to utilize the latest/cutting-edge features as soon as they are exposed via kubeadm.

  • As a developer/user I would like to experiment with different parameters with the understanding that I'm responsible for my own validation and troubleshooting.

Detailed Description

KubeadmControlPlane's kubeadmConfigSpeccurrently limits mutability to a subset of the available parameters. We would like to have a way to bypass/disable this limitation.

Anything else you would like to add:

Related Issues:

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 15, 2020
@Arvinderpal
Copy link
Contributor Author

One approach is to introduce a run-time flag to KCP (e.g. --enable-expert-mode) that bypasses these validation checks, and would essentially do the following:

allowedPaths := [][]string{
  {"spec", "*"},
  ...

@Arvinderpal
Copy link
Contributor Author

CC @alanmeadows @sb464f

@fabriziopandini
Copy link
Member

@Arvinderpal IMO this is a duplicate of #2083.
What about closing/dedupe by copying the above comments on this issue?

@Arvinderpal
Copy link
Contributor Author

Thanks @fabriziopandini. I'll update the other ticket.
/close

@k8s-ci-robot
Copy link
Contributor

@Arvinderpal: Closing this issue.

In response to this:

Thanks @fabriziopandini. I'll update the other ticket.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants