Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

⚠️ Default Kubelet cgroupDriver to systemd for Kubernetes >= 1.21 #4236

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
For Kubernetes >= 1.21, image builder is going to setup containerd for using systemd cgroup.
KCP should take care of adapting the Kubelet-Config map to be consistent with this change.

Which issue(s) this PR fixes:
Fixes #4099

/area control-plane
/milestone v0.4.0

/hold
for the change in image builder to be merged, rif kubernetes-sigs/image-builder#471

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Mar 1, 2021
@k8s-ci-robot k8s-ci-robot added area/control-plane Issues or PRs related to control-plane lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2021
@fabriziopandini
Copy link
Member Author

/retest

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

@fabriziopandini
Copy link
Member Author

fabriziopandini commented Mar 10, 2021

/hold cancel
PR merged in kubeadm and image builder (thanks @neolit123 & @codenrhoden), so we are ready to go in CAPI as well.
This should be back ported in the release 0.3 branch too
/assign @vincepri @CecileRobertMichon @detiber

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2021
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@vincepri vincepri changed the title ⚠️Default Kubelet cgroupDriver to systemd for Kubernetes >= 1.21 ⚠️ Default Kubelet cgroupDriver to systemd for Kubernetes >= 1.21 Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit cc47feb into kubernetes-sigs:master Mar 10, 2021
@fabriziopandini fabriziopandini deleted the default-cgroupDriver-to-systemd-for-1.21 branch March 11, 2021 09:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Issues or PRs related to control-plane lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use systemd cgroup manager when kubelet/containerd are managed by systemd unit
6 participants