-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
🌱 e2e: add option to configure both control-plane and workers machine template for k8s upgrade tests #6201
Conversation
5b9a93e
to
46d419f
Compare
…emplate for k8s upgrade tests Signed-off-by: Carlos Panato <ctadeu@gmail.com>
46d419f
to
04b1e36
Compare
Thank you very much! I think we should cherry-pick this to release-1.1 too, like the previous PR which added the first env var (otherwise it's just annoying to configure main and 1.1 e2e tests differently) I think it's fine that we replace the existing env var, given the stability guarantees we have for the test framework /assign @fabriziopandini |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@fabriziopandini PTAL, when you have some bandwidth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @cpanato for this improvement! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #6242 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
/assign @fabriziopandini @sbueringer
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Follow up of #6075 (comment)