Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🌱 e2e: add option to configure both control-plane and workers machine template for k8s upgrade tests #6201

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 24, 2022

What this PR does / why we need it:

  • add option to configure both control-plane and workers machine template for k8s upgrade tests

/assign @fabriziopandini @sbueringer

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Follow up of #6075 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2022
…emplate for k8s upgrade tests

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@sbueringer
Copy link
Member

sbueringer commented Feb 24, 2022

Thank you very much!
/lgtm

I think we should cherry-pick this to release-1.1 too, like the previous PR which added the first env var (otherwise it's just annoying to configure main and 1.1 e2e tests differently)
/cherry-pick release-1.1

I think it's fine that we replace the existing env var, given the stability guarantees we have for the test framework
@aartij17 @srm09 Please note that you have to update your jobs to the new env vars once you pick up this change.

/assign @fabriziopandini

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

Thank you very much!
/lgtm

I think we should cherry-pick this to release-1.1 to, like the previous PR which added the first env var (otherwise it's just annoying to configure main and 1.1 e2e tests differently)
/cherry-pick release-1.1

I think it's fine that we replace the existing env var, given the stability guarantees we have for the test framework
@aartij17 @srm09 Please note that you have to update your jobs to the new env vars once you pick up this change.

/assign @fabriziopandini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2022
@enxebre
Copy link
Member

enxebre commented Mar 1, 2022

/lgtm

@sbueringer
Copy link
Member

@fabriziopandini PTAL, when you have some bandwidth.

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

Thanks @cpanato for this improvement!
Hopefully, when switching to ClusterClass things will be simplified a little bit, but for now it is great to support this

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit eecabe4 into kubernetes-sigs:main Mar 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Mar 2, 2022
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #6242

In response to this:

Thank you very much!
/lgtm

I think we should cherry-pick this to release-1.1 too, like the previous PR which added the first env var (otherwise it's just annoying to configure main and 1.1 e2e tests differently)
/cherry-pick release-1.1

I think it's fine that we replace the existing env var, given the stability guarantees we have for the test framework
@aartij17 @srm09 Please note that you have to update your jobs to the new env vars once you pick up this change.

/assign @fabriziopandini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato deleted the upgrade-k8s-update branch March 3, 2022 09:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants