Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Finalize namespace #573

Closed
ialidzhikov opened this issue Aug 21, 2019 · 3 comments
Closed

Finalize namespace #573

ialidzhikov opened this issue Aug 21, 2019 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ialidzhikov
Copy link
Contributor

ialidzhikov commented Aug 21, 2019 •
edited
Loading

Because of legacy reasons namespaces in addition to .meta.finalizers have also .spec.finalizers. There is also a separate endpoint for the purpose PUT /api/{version}/namespaces/{namespace}/finalize - see https://github.com/kubernetes/community/blob/master/contributors/design-proposals/architecture/namespaces.md#rest-api and kubernetes/kubernetes#77086 (comment).

k8s.io/client-go has clientset.CoreV1().Namespaces().Finalize(ns) that can finalize namespace.

I would be great if controller-runtime client can also perform this action.
@DirectXMan12
Copy link
Contributor

/kind feature

I think we have someone working on generic subresource support, which would bring in this as well.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 22, 2019
@DirectXMan12
Copy link
Contributor

#172

@ialidzhikov
Copy link
Contributor Author

Ok, then closing this one in favour of #172.

DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@k8s-ci-robot
Merge pull request #573 from mengqiy/update_how_to_contribute_doc
a085eb8 
update how to deploy kubebuilder book
@pliurh pliurh mentioned this issue May 13, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DirectXMan12 @ialidzhikov @k8s-ci-robot