Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

NewDiscoveryRESTMapper returns errors, but contains an OrDie #613

Closed
DirectXMan12 opened this issue Sep 27, 2019 · 0 comments · Fixed by #622
Closed

NewDiscoveryRESTMapper returns errors, but contains an OrDie #613

DirectXMan12 opened this issue Sep 27, 2019 · 0 comments · Fixed by #622
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@DirectXMan12
Copy link
Contributor

pkg/client/apiutil.NewDiscoveryRESTMapper calls NewDiscoveryClientForConfigOrDie, which shouldn't be called outside other OrDie functions.

/kind bug
/priority critical-urgent
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Sep 27, 2019
@enxebre enxebre mentioned this issue Oct 1, 2019
Merged
DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@k8s-ci-robot
Merge pull request #613 from DirectXMan12/docs/design-template
4228ca5 
🏃 add a design folder and template
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
2 participants
@DirectXMan12 @k8s-ci-robot