Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

controller-gen unable to set file headers #464

Closed
chrislovecnm opened this issue Jul 16, 2020 · 7 comments · Fixed by #544
Closed

controller-gen unable to set file headers #464

chrislovecnm opened this issue Jul 16, 2020 · 7 comments · Fixed by #544
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@chrislovecnm
Copy link

This I believe is a feature request. It would be awesome to have controller-gen output file headers when you generate yaml files with the clip. When generating go code you are able to set a header file, but when you generate yaml it seems that does not work.

When providing the following options the yaml files do not contain a header.

controller-gen object:headerFile=./hack/boilerplate/boilerplate.yaml.txt rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases

Maybe I am missing something.

@coro
Copy link

coro commented Aug 13, 2020

I'd agree with this, would love to see this feature. We have a requirement to include license NOTICE headers in even our generated YAML, and this would allow us to perform this without manually injecting it after every run of controller-gen.

coro added a commit to rabbitmq/cluster-operator that referenced this issue Aug 13, 2020
This annoyed me that I'd get git diffs every time I ran controller-gen.
Until [this issue](kubernetes-sigs/controller-tools#464) is resolved, we must rely on this hack prepending script.
ChunyiLyu pushed a commit to rabbitmq/cluster-operator that referenced this issue Aug 25, 2020
This annoyed me that I'd get git diffs every time I ran controller-gen.
Until [this issue](kubernetes-sigs/controller-tools#464) is resolved, we must rely on this hack prepending script.
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 11, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justinsb
Copy link
Contributor

justinsb commented Jan 4, 2023

/reopen

Should we turn off the robot?

@k8s-ci-robot k8s-ci-robot reopened this Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

@justinsb: Reopened this issue.

In response to this:

/reopen

Should we turn off the robot?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants