Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

✨Upgrade to go 1.20 #803

Merged
merged 1 commit into from
Apr 24, 2023
Merged

✨Upgrade to go 1.20 #803

merged 1 commit into from
Apr 24, 2023

Conversation

Prajyot-Parab
Copy link
Contributor

  • Upgrade to go 1.20
  • Upgrade golangci-lint to v1.52.2
  • Fix lint findings

@Prajyot-Parab
Upgrade to go 1.20
227ea1e 
Signed-off-by: Prajyot-Parab <prajyot.parab2@ibm.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2023
camilamacedo86
camilamacedo86 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@vincepri
Copy link
Member

test-infra needs to be updated as well, before merging this PR

@Prajyot-Parab
Copy link
Contributor Author

test-infra needs to be updated as well, before merging this PR

PR - update controller-tools jobs to support go 1.20: kubernetes/test-infra#29356

@vincepri
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Prajyot-Parab, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6a6b7b8 into kubernetes-sigs:master Apr 24, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Prajyot-Parab @vincepri @k8s-ci-robot @camilamacedo86