Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add runtime handlers support #1847

Merged
merged 5 commits into from
Oct 17, 2018
Merged

Add runtime handlers support #1847

merged 5 commits into from
Oct 17, 2018

Conversation

runcom
Copy link
Member

@runcom runcom commented Oct 16, 2018 •
edited
Loading

This is the same as #1822 but rebased onto master to run the tests while waiting on a rebase there

runcom and others added 4 commits October 16, 2018 12:44
@runcom
vendor: update to kube 1.12
e1d01d9 
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom
container_create: honor readonly and masked paths from the CRI
48aa7ae 
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom
sandbox_run: skip sctp protocol hostport mapping
180a227 
ref containerd/cri#911

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom
cri: Implement runtime handler support
9d17af4 
Fixes cri-o#1751

Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
@runcom runcom requested a review from mrunalp as a code owner October 16, 2018 10:48
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from feiskyer October 16, 2018 10:48
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2018
@runcom
Copy link
Member Author

runcom commented Oct 16, 2018

/test all

@runcom runcom mentioned this pull request Oct 16, 2018
Closed
@runcom
Copy link
Member Author

runcom commented Oct 16, 2018

/test all

@runcom
Copy link
Member Author

runcom commented Oct 16, 2018

everything's cool here :)

@runcom
Copy link
Member Author

runcom commented Oct 16, 2018

2 green in a row, let's see again
/test all

@runcom
Copy link
Member Author

runcom commented Oct 16, 2018

flake
/test critest_rhel

@runcom
Copy link
Member Author

runcom commented Oct 16, 2018

/test kata-containers

@runcom runcom changed the title [DO NOT MERGE] runtime handler fixes Add runtime handlers support Oct 16, 2018
@runcom
Copy link
Member Author

runcom commented Oct 16, 2018

This is good to go assuming we're using this in favor of #1822

@sboeuf @mrunalp PTAL

@runcom runcom force-pushed the runcom_support_runtime_handler branch from 80c1140 to 7f93619 Compare October 17, 2018 10:14
@runcom
Copy link
Member Author

runcom commented Oct 17, 2018

/test all

@runcom
Copy link
Member Author

runcom commented Oct 17, 2018

@mrunalp @sboeuf PTAL

@runcom
config: provide a default runtime and deprecate the runtime option
da8ca84 
config: set default for runtimes

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

config: correctly check runtimes

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

config: deprecate runtime

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

runtime: provide a default from the handler map

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

fixes and validation

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

fix integration tests

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

amend test/helpers.bash

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

config: command line flags for runtimes

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom runcom force-pushed the runcom_support_runtime_handler branch from 7f93619 to da8ca84 Compare October 17, 2018 10:21
@runcom
Copy link
Member Author

runcom commented Oct 17, 2018

/test all

@runcom
Copy link
Member Author

runcom commented Oct 17, 2018

/test integration_rhel

@runcom
Copy link
Member Author

runcom commented Oct 17, 2018

/test e2e_fedora

sboeuf
sboeuf approved these changes Oct 17, 2018
View reviewed changes
Copy link

@sboeuf sboeuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @runcom
LGTM

@mrunalp
Copy link
Member

mrunalp commented Oct 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8bbac5e into cri-o:master Oct 17, 2018
@sboeuf
Copy link

sboeuf commented Oct 17, 2018

👍
@runcom @mrunalp Please let me know when you cut 1.12 😄

@runcom runcom deleted the runcom_support_runtime_handler branch October 18, 2018 09:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sboeuf sboeuf sboeuf approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@runcom @k8s-ci-robot @mrunalp @sboeuf