[release-1.31] Fix crictl info for containerd
#1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot just assume JSON objects because containerd will also return something like: ``` "golang": "go1.22.5", "lastCNILoadStatus": "OK", "lastCNILoadStatus.default": "OK", ``` For those values we just assume strings and prevent printing multiple double quotes to restore the v1.30.0 behavior of `crictl`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com> (cherry picked from commit 793c3e0)
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
saschagrunert
changed the title
crictl info for containerdcrictl info for containerd
k8s-ci-robot
added
the
size/S
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We cannot just assume JSON objects because containerd will also return something like:
For those values we just assume strings and prevent printing multiple double quotes to restore the v1.30.0 behavior of
crictl.Cherry picked from commit 793c3e0
Which issue(s) this PR fixes:
Fixes #1566
Forward port from #1568
Special notes for your reviewer:
This seems to be a regression and we may have to follow-up with v1.31.1
Does this PR introduce a user-facing change?