Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set StdinOnce to true for attach test #227

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

mrunalp
Copy link
Member

@mrunalp mrunalp commented Jan 25, 2018

Signed-off-by: Mrunal Patel mrunalp@gmail.com

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp
Copy link
Member Author

mrunalp commented Jan 25, 2018

We don't need to keep the stdin open for the test that we have.

@runcom
Copy link
Contributor

runcom commented Jan 25, 2018

LGTM

@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2018
@feiskyer feiskyer merged commit bb2c529 into kubernetes-sigs:master Jan 25, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants