Better support terminal #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Signed-off-by: Lantao Liu <lantaol@google.com>
Random-Liu
force-pushed
the
better-support-terminal
branch
from
1d2f31e to
a55a051
Compare
yujuhong
reviewed
Jul 12, 2018
cmd/crictl/exec.go
Outdated
| return exec.Stream(streamOptions) | ||
| if !tty { | ||
| return executor.Stream(streamOptions) | ||
| } else { |
Signed-off-by: Lantao Liu <lantaol@google.com>
Random-Liu
force-pushed
the
better-support-terminal
branch
from
a55a051 to
43a1bbe
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Merged
Random-Liu
added a commit
that referenced
this pull request
Jul 12, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288.
Fixes #181.
Add full terminal support: