Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable windows CI on travis #394

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Oct 15, 2018

Travis now adds support for Windows environment. This PR adds initial support for Windows building on travis and critest are disabled for Windows.

A few of following PRs will be added to fully support windows.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2018
@feiskyer feiskyer force-pushed the windows-ci branch 4 times, most recently from d438d3f to 3f76492 Compare October 15, 2018 12:57
@feiskyer
Copy link
Member Author

CI failed because of no enough space on disk. Seems this is a common issue of travis. refer https://travis-ci.community/t/there-is-not-enough-space-on-the-disk/338/3.

@feiskyer feiskyer closed this Oct 16, 2018
@feiskyer feiskyer reopened this Oct 16, 2018
@PatrickLang
Copy link

PatrickLang commented Oct 17, 2018

cc @jterry75 - FYI this is coming. Do you have any ideas on the disk space issue or how to use MSVC instead of GCC?

@feiskyer feiskyer force-pushed the windows-ci branch 6 times, most recently from 9937ddb to d68d5b8 Compare October 17, 2018 05:22
@feiskyer feiskyer changed the title WIP: Enable windows CI on travis Enable windows CI on travis Oct 17, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2018
@feiskyer feiskyer added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Oct 17, 2018
script:
- make
- hack/install-docker.sh
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubelet installation moved here, so that static check and build could be run more quickly.

git checkout "$branch"
}

# Build kubelet
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes makefile doesn't work on Windows, so here build kubelet directly by go build

@feiskyer
Copy link
Member Author

feiskyer commented Oct 17, 2018

CI green now.

/assign @Random-Liu

@Random-Liu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2018
@k8s-ci-robot k8s-ci-robot merged commit c616b23 into kubernetes-sigs:master Oct 23, 2018
@feiskyer feiskyer deleted the windows-ci branch October 23, 2018 02:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants