execute test suite only if the setup was successful

[snorwin]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Since the last changes ( #362) in the error handling of the setup functions, the test suite is also executed if the setup has failed. This can cause the tests to run to timeout because the expected prerequisites are not met. This PR introduces a check to ensure that the test suite is only executed if the setup was successful, otherwise the function returns with exit code 1 and the finish functions are gracefully executed.

Which issue(s) this PR fixes:

Fixes #423

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

The test suite is only executed if the setup was successful.

Additional documentation e.g., Usage docs, etc.:

[k8s-ci-robot]

Welcome @snorwin!

It looks like this is your first PR to kubernetes-sigs/e2e-framework 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/e2e-framework has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @snorwin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[snorwin]

Friendly ping for feedback to @harshanarayana and @ShwethaKumbla .
Thanks in advance 🙏

[harshanarayana]

/ok-to-test

[snorwin]

@harshanarayana thanks for triggering the tests, any chance that this PR is getting reviewed and released soon?

[cpanato]

/lgtm

[vladimirvivien]

This looks simple and it makes sense to be. But I think it will be impactful for existing users who may rely on that existing behavior. Are there cases where continuing with tests after a setup failure is good (I don't know, just asking).

cc @harshanarayana @cpanato

[snorwin]

@vladimirvivien The bug causing tests to run despite setup failures was introduced in v0.4.0 (commit: 70b0316). This caused test pipelines to timeout and generate strange error reports.

[harshanarayana]

@vladimirvivien I think it should be ok. Like @snorwin mentioned, this was a side effect of changes done in 70b0316.

Which is really recent change. So, making this change will only revert it back to the original behavior of how things were running with a slight change that the cleanup will happen due to graceful termination unlike the Fatal one before.

[harshanarayana]

/lgtm

[cpanato]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[snorwin]

@cpanato thanks for considering this fix. Is there a chance to get it released soon?

[cpanato]

i will check what we have to be released, but no plans for this week