-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add teardown when TestExecPod finished #436
Conversation
788d682
to
1696c66
Compare
@googs1025 Thanks for the work. Is this meant to be a fix in the framework code or an update in the example only ? I only see an update to the example code. |
Yes, I just modified the code in the example. |
@googs1025 ok thanks. Since this is just an example. Can you retitle the PR and remove "fix" ? I thought this was a fix for a bug. Thanks. |
OK, thanks for the comment. done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: googs1025, vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., Usage docs, etc.: