Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add teardown when TestExecPod finished #436

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

googs1025
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • add teardown when TestExecPod finished

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Additional documentation e.g., Usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 2, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 2, 2024
@googs1025 googs1025 force-pushed the fix_teardown branch 3 times, most recently from 788d682 to 1696c66 Compare July 2, 2024 08:39
@vladimirvivien
Copy link
Contributor

@googs1025 Thanks for the work. Is this meant to be a fix in the framework code or an update in the example only ? I only see an update to the example code.

@googs1025
Copy link
Member Author

@googs1025 Thanks for the work. Is this meant to be a fix in the framework code or an update in the example only ? I only see an update to the example code.

Yes, I just modified the code in the example.

@vladimirvivien
Copy link
Contributor

@googs1025 ok thanks. Since this is just an example. Can you retitle the PR and remove "fix" ? I thought this was a fix for a bug. Thanks.

@googs1025 googs1025 changed the title fix: add teardown when TestExecPod finished add teardown when TestExecPod finished Jul 8, 2024
@googs1025
Copy link
Member Author

@googs1025 ok thanks. Since this is just an example. Can you retitle the PR and remove "fix" ? I thought this was a fix for a bug. Thanks.

OK, thanks for the comment. done

Copy link
Contributor

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: googs1025, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 950e125 into kubernetes-sigs:main Jul 15, 2024
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants