Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: flux kyverno tests & return stderr while reading kubeconfig via kwokctl #438

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

prit342
Copy link
Contributor

@prit342 prit342 commented Jul 11, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • This PR ensures that the error message from kwokctl get kubeconfig is captured and returned as part of the wrapped error
  • Also fixes the flaky flux kyverno tests by ensuring that the kyverno related deployments are available before the tests are launched

Which issue(s) this PR fixes:

Fixes #440

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Additional documentation e.g., Usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 11, 2024
Copy link

linux-foundation-easycla bot commented Jul 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: prit342 / name: Prithak S. (4d554ee)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @prit342!

It looks like this is your first PR to kubernetes-sigs/e2e-framework 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/e2e-framework has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @prit342. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 11, 2024
@cpanato
Copy link
Member

cpanato commented Jul 12, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 12, 2024
@prit342
Copy link
Contributor Author

prit342 commented Jul 12, 2024

The tests directly affected by this PR sigs.k8s.io/e2e-framework/examples/kwok/kwok_with_config are passing successfully. However, sigs.k8s.io/e2e-framework/examples/third_party_integration/flux/kyverno tests in the suite are currently failing which this PR does not affect.

@prit342
Copy link
Contributor Author

prit342 commented Jul 12, 2024

/retest

@prit342 prit342 force-pushed the kwok-return-stderr branch 3 times, most recently from 68773c8 to 510d298 Compare July 12, 2024 14:43
@harshanarayana
Copy link
Contributor

xref: #440

Created a tracker for the kyverno failures. That test has been flaking to much lately. cc @vladimirvivien @cpanato

I will take a look at this over the weekend to get it fixed.

@prit342 prit342 force-pushed the kwok-return-stderr branch from 510d298 to 4d554ee Compare July 12, 2024 21:17
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2024
@prit342
Copy link
Contributor Author

prit342 commented Jul 12, 2024

Thank you @harshanarayana for the pointers related to the flaky tests. I've added logic to check for the availability of all Kyverno related deployments before running tests. And after this change, the tests have not failed in subsequent runs. As indicated previously the tests related to sigs.k8s.io/e2e-framework/examples/kwok/kwok_with_config are passing successfully.

CC @vladimirvivien @cpanato

@prit342 prit342 changed the title fix: return stderr while reading kubeconfig via kwokctl fix: flux kyverno tests & return stderr while reading kubeconfig via kwokctl Jul 12, 2024
@cpanato
Copy link
Member

cpanato commented Jul 15, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2024
@harshanarayana
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshanarayana, prit342

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 79cc0b2 into kubernetes-sigs:main Jul 16, 2024
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flux Integration test with kyverno is flaking
4 participants