-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: flux kyverno tests & return stderr while reading kubeconfig via kwokctl #438
Conversation
|
Welcome @prit342! |
Hi @prit342. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
The tests directly affected by this PR |
/retest |
68773c8
to
510d298
Compare
xref: #440 Created a tracker for the kyverno failures. That test has been flaking to much lately. cc @vladimirvivien @cpanato I will take a look at this over the weekend to get it fixed. |
510d298
to
4d554ee
Compare
Thank you @harshanarayana for the pointers related to the flaky tests. I've added logic to check for the availability of all Kyverno related deployments before running tests. And after this change, the tests have not failed in subsequent runs. As indicated previously the tests related to |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshanarayana, prit342 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
kwokctl get kubeconfig
is captured and returned as part of the wrapped errorWhich issue(s) this PR fixes:
Fixes #440
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
None
Additional documentation e.g., Usage docs, etc.:
None