-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conformance: fix Listener ConditionReason #1305
Conformance: fix Listener ConditionReason #1305
Conversation
In the "GatewaySecretInvalidReferenceGrant" and "GatewaySecretMissingReferenceGrant" conformance tests for gateways, the expected condition has been changed from InvalidCertificateRef to RefNotPermitted. Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Welcome @mlavacca! |
Hi @mlavacca. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for identifying this problem and resolving it 🖖
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…eason RefNotPermitted See kubernetes-sigs/gateway-api#1305 Fixes conformance test failures on main Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Release 0.5.x: Cherry-pick #1305
…eason RefNotPermitted (#4664) See kubernetes-sigs/gateway-api#1305 and kubernetes-sigs/gateway-api#1334 Fixes conformance test failures on main Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
What type of PR is this?
/kind bug
What this PR does / why we need it:
In the "GatewaySecretInvalidReferenceGrant" and "GatewaySecretMissingReferenceGrant" conformance tests for gateways, the expected condition has been changed from
InvalidCertificateRef
toRefNotPermitted
.Which issue(s) this PR fixes:
Fixes #1297
Does this PR introduce a user-facing change?: