Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add annotation about ResourceQuota for HRQ implementation to some documents #340

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Add annotation about ResourceQuota for HRQ implementation to some documents #340

merged 1 commit into from
Oct 27, 2023

Conversation

mochizuki875
Copy link
Member

What type of PR is this?:

/kind documentation
/kind cleanup

What this PR does / why we need it:

As discussed #301 (comment), I've added annotation about ResourceQuota for HRQ internal implementation as Note section.
In addition, the expression of the Note section was different depending on each the document, so I've unified them.

Tested:

None(Only document fix)

Related:

#275
#301 (comment)

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2023
@rjbez17
Copy link
Contributor

rjbez17 commented Oct 27, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mochizuki875, rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 65a8ec6 into kubernetes-sigs:master Oct 27, 2023
@mochizuki875 mochizuki875 mentioned this pull request Oct 27, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adrianludwin adrianludwin Awaiting requested review from adrianludwin

@rjbez17 rjbez17 Awaiting requested review from rjbez17

Assignees

@rjbez17 rjbez17

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mochizuki875 @rjbez17 @k8s-ci-robot