Allow customize kubernetes, cni source #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
detiber
reviewed
Aug 13, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: figo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
detiber
reviewed
Aug 14, 2019
moshloop
reviewed
Aug 14, 2019
moshloop
reviewed
Aug 14, 2019
moshloop
reviewed
Aug 14, 2019
the image-builder tool getting kubernetes, cni from two types of source: 1) rpm, deb repos, container registry 2) binary download site the default behaviour does not change, still getting them from upstream rpm, deb repo and k8s. gcr.io. this change enable us to configure rpm, deb source and binary source for kuberentes, cni one more change needed to allow configure container registry source. nit: Set packer variable default to null so that it report error if user does not set those vars, those vars need be set through json Signed-off-by: Hui Luo <luoh@vmware.com>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the image-builder tool getting kubernetes, cni from two source types:
the default behavior does not change, still getting them from upstream rpm, deb repo and k8s. gcr.io. this change enable us to configure rpm,deb source and binary source for kuberentes, cni
note: one more change needed to allow customize container registry for k8s images.
Signed-off-by: Hui Luo luoh@vmware.com
cc @codenrhoden @akutz @moshloop @timothysc