-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
🌱 cleanup/refactor: Alpha Generate command #4180
base: master
Are you sure you want to change the base?
🌱 cleanup/refactor: Alpha Generate command #4180
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
168a6c9
to
6863474
Compare
/test pull-kubebuilder-e2e-k8s-1-31-0 |
1a4f851
to
9f0bcd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have now very compreensive e2e tests see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/e2e/alphagenerate/generate_test.go
So, if pass on the tests the changes are OK.
But I would like your input / review here if you have time.
Just to ensure that you agree with the changes and mainly about we are moving the code implementation. The pkg does not seems a good place for we add the code implementation for commands like that.
I mean, we are not really want to provide it as pkg/api method right
we probably either should use internal dir here to not export.
- Refactored the code implementation to improve error handling, encapsulate logic, and streamline execution flow. - Moved the code implementation from `pkg` to the CLI since it pertains directly to a command. - Additionally, moved the implementation to `internal` to prevent exposing the `Generate` code and avoid unintentional extensions on this alpha feature.
9f0bcd3
to
33e24da
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
pkg
to the CLI since it pertains directly to a command.internal
to prevent exposing theGenerate
code and avoid unintentional extensions on this alpha feature.Motivation
Ensure better maintenance ability
Not allow unintentional extensions on this alpha feature.