🐛 revert the changes done in the PR #4286 #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are reverting the changes done in the PR kubernetes-sigs#4286. We are just keeping the e2e tests improvements. We will not able to solve the issue kubernetes-sigs#4146 without add new markers. We cannot skip the action to write an webhook since it will result in incomplete inplementation in the <kind>_webhook.go as in the <kind>_webhook_test.go
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
I am just reverting the silly fix for #4286 which end up not been so silly ;-) |
camilamacedo86
added
the
lgtm
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are reverting the changes done in the PR #4286. We are just keeping the e2e tests improvements.
We will not able to solve the issue #4146 without add new markers.
We cannot skip the action to write an webhook since it will result in incomplete inplementation in the _webhook.go as in the _webhook_test.go