-
Notifications
You must be signed in to change notification settings - Fork 531
add helm parameter imagePullSecrets #1325
add helm parameter imagePullSecrets #1325
Conversation
Welcome @huiwq1990! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@huiwq1990 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huiwq1990 Please, update the README to add the new property.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, huiwq1990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR aims to implement this feature: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ , allow use set private registry credentials. Demo shows below:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: