Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix kubernetes master roles defaults #4069

Closed

Conversation

dannyk81
Copy link
Contributor

As I was trying to deploy Kubespray, I noticed that kubernetes/master defaults directory had a main sub-directory where main.yml and kube-proxy.yml were stored, so Ansible would not pick them up and I got a bunch of variable undefined errors.

Did two things:

  1. move roles/kubernetes/master/defaults/main/main.yml to roles/kubernetes/master/defaults/main.yml
  2. merged roles/kubernetes/master/defaults/main/kube-proxy.yml into roles/kubernetes/master/defaults/main.yml

(2) above was needed, since this separate defaults file is never loaded, also causing variable undefined errors.

I'm using Ansible 2.6.0.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dannyk81
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: woopstar

If they are not already assigned, you can assign the PR to them by writing /assign @woopstar in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ant31 and mirwan January 18, 2019 15:39
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 18, 2019
@dannyk81
Copy link
Contributor Author

/assign @woopstar

@chadswen
Copy link
Member

This is actually supported (and encouraged for large defaults files) since ansible 2.6. PR

Perhaps there's an issue with the feature in 2.6.0? Can you try a more recent patch version of 2.6.x?

@dannyk81
Copy link
Contributor Author

@chadswen sure, let me upgrade to 2.6.12 and try without this.

@dannyk81
Copy link
Contributor Author

@chadswen indeed, with 2.6.12 this works as-is.

Perhaps worth updating the requirements to state that >2.6.12 is needed (perhaps eariler... not sure), for sure this is broken with 2.6.0

@dannyk81 dannyk81 closed this Jan 18, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants