-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add helm chart repository #2377
Add helm chart repository #2377
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
c9362dd
to
c828229
Compare
10a2a76
to
84b783e
Compare
/assign |
e712c52
to
31602f2
Compare
ebe4dea
to
789677c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this is merged and we have "production confirmation" that it works as we expect we showed follow-up on:
- check if we are also able to promote the charts to registry.k8s.io
- drop the old build method (release artifacts)
- update the install related documentation
/lgtm
LGTM label has been added. Git tree hash: dceb1b97d8c764987b722746d0f1e7702bcc683e
|
/assign @alculquicondor |
A package publication on https://artifacthub.io/ whould be nice as a follow up, too. |
/release-note-edit
Assuming that we can promote the image there. If it doesn't work, we can revert this PR. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, IrvingMg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It looks like the objects are properly listed in gcr.io/k8s-staging-kueue/charts/kueue Should it be gcr.io/k8s-staging-kueue/kueue/charts instead? |
Also, can you test those objects to see if they work properly? |
It's possible to change the path but Helm creates a subdirectory for the chart at the end. So if we change it, the resulting path would be
It seems to be working as expected, I ran: helm install kueue oci://gcr.io/k8s-staging-kueue/charts/kueue --version v20240619-v0.8.0-devel-54-g81ad017a and got
|
I left a question in the k8s-infra slack channel https://kubernetes.slack.com/archives/CCK68P2Q2/p1718819420490889 |
Nobody should be consuming from gcr.io/k8s-staging-kueue directly anyhow (in fact we will have to move the staging locations to artifact registry later this year) so the path doesn't matter all that much there, when promoted to registry.k8s.io the path can be different. |
From slack thread:
|
/release-note-edit
Because #2476 didn't merge and I don't know if it's safe to do so. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add Helm chart repository.
Which issue(s) this PR fixes:
Fixes #2311
Special notes for your reviewer:
Does this PR introduce a user-facing change?