Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Automated cherry pick of #3350: reset admission check after deactivation #3518

Conversation

KPostOffice
Copy link
Contributor

Cherry pick of #3350 on release-0.9.

#3350: reset admission check after deactivation

For details on the cherry pick process, see the cherry pick requests page.

Fix the flow of deactivation for workloads due to rejected AdmissionChecks. 
Now, all AdmissionChecks are reset back to the Pending state on eviction (and deactivation in particular), 
and so an admin can easily re-activate such a workload manually without tweaking the checks.

Signed-off-by: Kevin <kpostlet@redhat.com>
Signed-off-by: Kevin <kpostlet@redhat.com>
Signed-off-by: Kevin <kpostlet@redhat.com>
Signed-off-by: Kevin <kpostlet@redhat.com>
Signed-off-by: Kevin <kpostlet@redhat.com>
Signed-off-by: Kevin <kpostlet@redhat.com>
Signed-off-by: Kevin <kpostlet@redhat.com>
Signed-off-by: Kevin <kpostlet@redhat.com>
Signed-off-by: Kevin <kpostlet@redhat.com>
Signed-off-by: Kevin <kpostlet@redhat.com>
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Nov 12, 2024
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 12, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @KPostOffice. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 4d5835a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6734dd60ad23f20008f9caf2

@kannon92
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 13, 2024

@KPostOffice PTAL on the failures

@mimowo mimowo mentioned this pull request Nov 13, 2024
36 tasks
Signed-off-by: Kevin <kpostlet@redhat.com>
@mimowo
Copy link
Contributor

mimowo commented Nov 13, 2024

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4bae9fb3583132b237b7c734e421924e0b561fec

@k8s-ci-robot k8s-ci-robot merged commit abe6931 into kubernetes-sigs:release-0.9 Nov 13, 2024
16 checks passed
@mimowo
Copy link
Contributor

mimowo commented Nov 13, 2024

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants