fix: xterm copy-out logic is erratic with line wrapping #8902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when capturing the output of the pty, line wrapping causes odd behavior, with lines squashed together strangely
this might be due to some webpack or typescript behavior for variables declared but never defined before first use? we were assuming it was
undefined
, but... this doesn't appear to be the case? in any case, we shouldn't be using variables with no defined value.Description of what you did:
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs