Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Can't set annotation with colons #818

Closed
sirkonst opened this issue Feb 25, 2019 · 1 comment
Closed

Can't set annotation with colons #818

sirkonst opened this issue Feb 25, 2019 · 1 comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@sirkonst
Copy link 

$ kustomize edit add annotation -- project/url:http://my_awesome_project
Error: invalid annotation: project/url:http://my_awesome_project (too many colons)
...

$ kustomize version 
Version: {KustomizeVersion:2.0.1 GitCommit:ce7e5ee2c30cc5856fea01fe423cf167f2a2d0c3 BuildDate:2019-02-08T00:57:04Z GoOs:unknown GoArch:unknown}

:-(
@Liujingfang1 Liujingfang1 added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 27, 2019
@Liujingfang1
Copy link
Contributor

This can be fixed by accepting

kustomize edit add annotation annotationKey:"annotationValue"

@narayanan narayanan mentioned this issue Mar 2, 2019
Merged
monopole added a commit that referenced this issue Mar 5, 2019
@monopole
Merge pull request #842 from narayanan/annotation-with-colon
a6f6514 
Fix for #818 - Added support for quoted values
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sirkonst @Liujingfang1