Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

support inline transformer and generator #3225

Merged
merged 1 commit into from
Nov 13, 2020
Merged

support inline transformer and generator #3225

merged 1 commit into from
Nov 13, 2020

Conversation

Shell32-Natsu
Copy link
Contributor

close #3199

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2020
monopole
monopole approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@monopole monopole merged commit a25300d into kubernetes-sigs:master Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole, Shell32-Natsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Shell32-Natsu,monopole]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Shell32-Natsu Shell32-Natsu deleted the inline-transformer branch November 13, 2020 18:06
hatfieldbrian added a commit to hatfieldbrian/ramen that referenced this pull request Sep 22, 2021
@hatfieldbrian
add Deployment match and template and Service selector labels contain…
5f366d4 
…ing operator name RamenDR#277

	- install kustomize version 3.8.8 including inline transformer support for hub and dr-cluster deployments
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv3.8.8
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/api%2Fv0.6.6
		- kubernetes-sigs/kustomize#3225

Signed-off-by: hatfieldbrian <bhatfiel@redhat.com>
hatfieldbrian added a commit to hatfieldbrian/ramen that referenced this pull request Sep 23, 2021
@hatfieldbrian
label Deployment, ReplicaSet, Pod, and Service with operator name Ram…
8224f2d 
…enDR#277

	- increase kustomize version from 3.8.7 to 3.8.8 for inline transformer support
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv3.8.8
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/api%2Fv0.6.6
		- kubernetes-sigs/kustomize#3225
		- user must remove existing bin/kustomize if its version is less than 3.8.8

Signed-off-by: hatfieldbrian <bhatfiel@redhat.com>
ShyamsundarR pushed a commit to RamenDR/ramen that referenced this pull request Sep 23, 2021
@hatfieldbrian @ShyamsundarR
label Deployment, ReplicaSet, Pod, and Service with operator name #277
67dfd1e 
	- increase kustomize version from 3.8.7 to 3.8.8 for inline transformer support
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv3.8.8
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/api%2Fv0.6.6
		- kubernetes-sigs/kustomize#3225
		- user must remove existing bin/kustomize if its version is less than 3.8.8

Signed-off-by: hatfieldbrian <bhatfiel@redhat.com>
ShyamsundarR pushed a commit to red-hat-storage/ramen that referenced this pull request Sep 23, 2021
@hatfieldbrian @ShyamsundarR
label Deployment, ReplicaSet, Pod, and Service with operator name #277
99b0d68 
	- increase kustomize version from 3.8.7 to 3.8.8 for inline transformer support
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv3.8.8
		- https://github.com/kubernetes-sigs/kustomize/releases/tag/api%2Fv0.6.6
		- kubernetes-sigs/kustomize#3225
		- user must remove existing bin/kustomize if its version is less than 3.8.8

Signed-off-by: hatfieldbrian <bhatfiel@redhat.com>
@TLDMain TLDMain mentioned this pull request Aug 13, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@monopole monopole monopole approved these changes

Assignees

@monopole monopole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow inlined plugin configuration in kustomization.yaml file
3 participants
@Shell32-Natsu @k8s-ci-robot @monopole