WIP: kustomize edit fix command will copy and compare output #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
approved
|
/retest |
natasha41575
force-pushed
the
KustomizeFix
branch
3 times, most recently
from
9948ce2 to
b0504b4
Compare
k8s-ci-robot
added
size/L
natasha41575
changed the title
natasha41575
force-pushed
the
KustomizeFix
branch
7 times, most recently
from
afc5298 to
ab8f7ca
Compare
natasha41575
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
natasha41575
force-pushed
the
KustomizeFix
branch
from
8ca24c5 to
9c5e9ee
Compare
natasha41575
force-pushed
the
KustomizeFix
branch
from
9c5e9ee to
bbc737b
Compare
natasha41575
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Please pull the golang lint change to it's own PR. |
natasha41575
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
closing this PR until we have a better solution |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a small part of #3849.
kustomize edit fixshould compare the new output against the old, and throw an error if they don't match.I was struggling to write a test case in which this throws an error, because I was having trouble thinking of an existing scenario when
kustomize edit fixwouldn't produce the same output. Some suggestions for potential tests will be helpful, and there will be more tests for failure cases after the next PR, which will convertvarstoreplacements.ALLOW_MODULE_SPAN
EDIT: There is a lint issue: #3663; and fixed for kyaml by this commit here. The first commit in this PR brought up the same problem, but for the kustomize module. The second commit in this PR fixes it by downgrading golangci-lint for the kustomize module to v1.17.0.