Remove fix kustomization step before Unmarshalling the yaml structure

[koba1t]

• Remove the FixKustomizationPreUnmarshalling function.
• Move convert code for the deprecated field for imageTags to after unmarshalling.
• Show a warning message when using the imageTags at this line.

This has already been talked about at #4723 (comment)

related PR

• drop support for legacy patches #4911

/cc @KnVerey @natasha41575

[koba1t]

/cc @natasha41575

[natasha41575]

Thanks for this PR! This seems like a reasonable way to handle imageTags. I'm holding off on approving so that @KnVerey can take a look too.

@annasong20 With this change, localize will also stop auto-converting imageTags to images, which will be really nice.

/lgtm

[natasha41575]

@koba1t when #4918 is merged, could you rebase this PR? #4918 makes a call toFixKustomizationPreUnmarshalling, but you can just remove those lines after you rebase and update any failing tests accordingly. Feel free to reach out if this isn't clear or if you run into any other problems with the localizer code.

[annasong20]

@koba1t In #4918, same PR that @natasha41575 mentions above, images in this line: https://github.com/kubernetes-sigs/kustomize/pull/4918/files#diff-c21f7b3d0afda4a64163411e90e72d2fed6c3df14c7b6f8ed07237bb5e1fc91cR213 will also need to be changed to imageTags. Feel free to ping me with any problems.

[koba1t]

@natasha41575 @annasong20
I was done to rebase master and fix at #4923 (comment) line.
All tests and lint were passed.

Could you check it?

[natasha41575]

/lgtm

[natasha41575]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment