Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[release-0.6] Fix broken links dependency for prometheus component #1246

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Oct 23, 2024

This is an cherry-pick of #1225

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2024
@k8s-ci-robot
Copy link
Contributor

@wzshiming: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kwok-unit-test-main 872a58d link true /test pull-kwok-unit-test-main
pull-kwok-verify-main 872a58d link true /test pull-kwok-verify-main
pull-kwok-build-main 872a58d link true /test pull-kwok-build-main
pull-kwok-e2e-test-main 872a58d link true /test pull-kwok-e2e-test-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit 872a58d
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6718d0d65df7ad0008632bb7
😎 Deploy Preview https://deploy-preview-1246--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wzshiming wzshiming changed the base branch from main to release-0.6 October 23, 2024 10:33
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 23, 2024
@wzshiming wzshiming force-pushed the cherry-pick-1225-to-release-0.6 branch from 872a58d to 4152e47 Compare October 23, 2024 10:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wzshiming wzshiming force-pushed the cherry-pick-1225-to-release-0.6 branch from 4152e47 to be71e2d Compare October 24, 2024 03:08
@wzshiming wzshiming merged commit 1cbeae7 into kubernetes-sigs:release-0.6 Oct 25, 2024
16 of 17 checks passed
@wzshiming wzshiming deleted the cherry-pick-1225-to-release-0.6 branch October 25, 2024 05:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants