-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Dynamic Kubelet Configuration #281
Comments
Alpha PR: kubernetes/kubernetes#46254 |
Punt this to v1.8. |
Automatic merge from submit-queue (batch tested with PRs 50016, 49583, 49930, 46254, 50337) Alpha Dynamic Kubelet Configuration Feature: kubernetes/enhancements#281 This proposal contains the alpha implementation of the Dynamic Kubelet Configuration feature proposed in ~#29459~ [community/contributors/design-proposals/dynamic-kubelet-configuration.md](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/dynamic-kubelet-configuration.md). Please note: - ~The proposal doc is not yet up to date with this implementation, there are some subtle differences and some more significant ones. I will update the proposal doc to match by tomorrow afternoon.~ - ~This obviously needs more tests. I plan to write several O(soon). Since it's alpha and feature-gated, I'm decoupling this review from the review of the tests.~ I've beefed up the unit tests, though there is still plenty of testing to be done. - ~I'm temporarily holding off on updating the generated docs, api specs, etc, for the sake of my reviewers 😄~ these files now live in a separate commit; the first commit is the one to review. /cc @dchen1107 @vishh @bgrant0607 @thockin @derekwaynecarr ```release-note Adds (alpha feature) the ability to dynamically configure Kubelets by enabling the DynamicKubeletConfig feature gate, posting a ConfigMap to the API server, and setting the spec.configSource field on Node objects. See the proposal at https://github.com/kubernetes/community/blob/master/contributors/design-proposals/dynamic-kubelet-configuration.md for details. ```
@mtaufen Any user/admin-facing docs ready for this feature? |
No, I really need to write something to teach people how to play with the alpha. What's the preferred place for these docs again? |
@mtaufen https://kubernetes.io/docs (https://github.com/kubernetes/kubernetes.github.io) |
Done |
Looks like the proposal has moved to: @mtaufen Want to update the link in the description? |
Done, thanks! |
https://github.com/kubernetes/enhancements/tree/2cd758cc6ab617a93f578b40e97728261ab886ed/keps/sig-node/281-dynamic-kubelet-configuration states that the removal from the API server happens in Kubernetes v1.26 That makes me think we should reopen and track this. |
@sftim: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubernetes/kubernetes#112643 is WIP for it. |
/remove-lifecycle rotten |
See kubernetes/kubernetes#112643 (comment) for the approved exception request for v1.26. |
/label lead-opted-in |
@leonardpahlke: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
let me see if i have perm haha |
:D whatt, I guess we can add |
@gracenng: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @mtaufen and @SergeyKanzhelev 👋, Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022. Please ensure the following items are completed:
For the deprecation, please let me know if we should tracking any PRs beyond #3605. I have this marked as As always, we are here to help should questions come up. Thanks! |
Hello @mtaufen 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release. Please follow the steps detailed in the documentation to open a PR against Any doubt, reach us! Thank you! |
Closing this issue since this feature has been on the deprecation track for a while. kubernetes/kubernetes#102966 |
@SergeyKanzhelev FYI |
Dynamic Kubelet Configuration
New Kubelet configurations can be rolled out in a live cluster
Node.Spec.ConfigSource
node authorizer sets up access rules for dynamic config kubernetes#60100pkg/kubelet/kubeletconfig/util/files/files.go
):--dynamic-config-dir
, other docs updates for 1.11The text was updated successfully, but these errors were encountered: