Skip to content

KEP-1959: promote loadbalancerclass feature to beta in v1.22. #2698

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

XudongLiuHarold
Copy link
Member

Update Beta graduation criteria and answer PRR questions for beta.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @XudongLiuHarold!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @XudongLiuHarold. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2021
@XudongLiuHarold XudongLiuHarold changed the title KEP-1959: update kep-1959 loadbalancerclass to promote the feature to beta. KEP-1959: update kep-1959 to promote loadbalancerclass feature to beta. May 9, 2021
@XudongLiuHarold
Copy link
Member Author

/assign @andrewsykim

@XudongLiuHarold XudongLiuHarold changed the title KEP-1959: update kep-1959 to promote loadbalancerclass feature to beta. KEP-1959: promote loadbalancerclass feature to beta in v1.22. May 9, 2021
@andrewsykim
Copy link
Member

/assign @thockin

@andrewsykim
Copy link
Member

/assign @deads2k

For PRR

@wojtek-t
Copy link
Member

/assign @johnbelamaric

John - you removed alpha - so maybe you can also review beta?

/unassign @deads2k

@johnbelamaric
Copy link
Member

PRR looks good as far as content, but you need to add a "beta" section to the PRR file.

@thockin
Copy link
Member

thockin commented May 10, 2021

/lgtm

OK for content

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 10, 2021
@XudongLiuHarold
Copy link
Member Author

XudongLiuHarold commented May 11, 2021

PRR looks good as far as content, but you need to add a "beta" section to the PRR file.

Hi @johnbelamaric , thanks, updated! And is that ok I still put you on the approver?

@XudongLiuHarold
Copy link
Member Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@XudongLiuHarold: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hanlins
Copy link
Member

hanlins commented May 11, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2021
@XudongLiuHarold
Copy link
Member Author

/retest

@hanlins
Copy link
Member

hanlins commented May 11, 2021

Hi @XudongLiuHarold, besides the changes in README, I think you also need to update the kep.yaml file accordingly. Update the maturity

# The target maturity stage in the current dev cycle for this KEP.
stage: alpha
last milestone
# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.21"
and append the expected beta release cycle
# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.21"

Copy link
Member

@hanlins hanlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the kep.yaml file.

Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor administrative tweaks needed

Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 11, 2021
@andrewsykim
Copy link
Member

@XudongLiuHarold can you clean up the commit history?

@XudongLiuHarold
Copy link
Member Author

XudongLiuHarold commented May 11, 2021

@XudongLiuHarold can you clean up the commit history?

Sure, updated, @andrewsykim could you approve again 😅 , thanks!

@XudongLiuHarold XudongLiuHarold force-pushed the promote-loadbalancerclass-to-beta branch from 0c7c0a0 to 27475a2 Compare May 11, 2021 23:34
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2021
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, johnbelamaric, XudongLiuHarold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2021
@andrewsykim
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2021
@hanlins
Copy link
Member

hanlins commented May 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 55721cf into kubernetes:master May 12, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 12, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants