-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-1959: promote loadbalancerclass feature to beta in v1.22. #2698
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
KEP-1959: promote loadbalancerclass feature to beta in v1.22. #2698
Conversation
Welcome @XudongLiuHarold! |
Hi @XudongLiuHarold. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @andrewsykim |
/assign @thockin |
/assign @deads2k For PRR |
/assign @johnbelamaric John - you removed alpha - so maybe you can also review beta? /unassign @deads2k |
PRR looks good as far as content, but you need to add a "beta" section to the PRR file. |
/lgtm OK for content |
Hi @johnbelamaric , thanks, updated! And is that ok I still put you on the approver? |
/ok-to-test |
@XudongLiuHarold: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
Hi @XudongLiuHarold, besides the changes in README, I think you also need to update the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the kep.yaml
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor administrative tweaks needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/hold
@XudongLiuHarold can you clean up the commit history? |
Sure, updated, @andrewsykim could you approve again 😅 , thanks! |
0c7c0a0
to
27475a2
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, johnbelamaric, XudongLiuHarold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/lgtm |
Update Beta graduation criteria and answer PRR questions for beta.