KEP-3573: Graduate Kubelet DeviceManager to GA #3574
Conversation
This commit obtains the original proposal from here: https://github.com/kubernetes/design-proposals-archive/blob/main/resource-management/device-plugin.md. Translation to the latest KEP format and updates pertaining to GA graduation will be done in subsequent commits. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
swatisehgal
force-pushed
the
devicemanager-ga-graduation
branch
3 times, most recently
from
6d44867 to
185bbde
Compare
swatisehgal
force-pushed
the
devicemanager-ga-graduation
branch
from
185bbde to
2b95eca
Compare
swatisehgal
force-pushed
the
devicemanager-ga-graduation
branch
from
2b95eca to
5102aea
Compare
swatisehgal
force-pushed
the
devicemanager-ga-graduation
branch
9 times, most recently
from
5102aea to
ad61bb5
Compare
|
/retest |
swatisehgal
force-pushed
the
devicemanager-ga-graduation
branch
4 times, most recently
from
f102456 to
a22796b
Compare
swatisehgal
force-pushed
the
devicemanager-ga-graduation
branch
from
058cb3e to
b1f1c08
Compare
swatisehgal
force-pushed
the
devicemanager-ga-graduation
branch
3 times, most recently
from
a55a295 to
92c9b4a
Compare
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
- Updates to capture latest device API changes. - Capture upgrade and version skew strategy to capture the correct state since device plugin graduation to Beta in Kubernetes v1.10. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
Reference: https://github.com/kubernetes/kubernetes/blob/release-1.25/pkg/kubelet/metrics/metrics.go#L61-L62 Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
swatisehgal
force-pushed
the
devicemanager-ga-graduation
branch
from
92c9b4a to
43f16a1
Compare
|
lgtm from node perspective (non binding) |
|
/cc @mrunalp for awareness |
|
|
||
| ###### What are the reasonable SLOs (Service Level Objectives) for the enhancement? | ||
|
|
||
| Not Applicable, refer to Kubelet SLOs. |
There was a problem hiding this comment.
device_plugin_alloc_duration_seconds seems reasonable to check and decide how long is too long.
|
@fromanirh: GitHub didn't allow me to request PR reviews from the following users: for, awareness. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
|
PRR lgtm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @dchen1107 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, deads2k, swatisehgal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Issue link: Add Device Manager to kubelet #3573
Other comments:
The original proposal ended up in the archived design proposal repo here and hence was imported from there and ported to the latest KEP format. In addition to that, the KEP was updated to reflect the more up-to-date state of device plugins API and the version skew strategy.
NOTE: The graduation of Device Plugin API to GA is out of scope of this KEP and will be covered in a separate KEP in the future. Discussion on this topic can be found here.