KEP-3953: Node Resource Hot Plug

[Karthik-K-N]

• One-line PR description: Node Resource Hot Plug

• Issue link: Node Resource Hot Plug #3953

• Other comments:

[bart0sh]

/assign @mrunalp @SergeyKanzhelev @klueska

[kad]

/cc

[ffromani]

/cc

[fmuyassarov]

/cc

[Karthik-K-N]

Sure, as long as that part isn't changed, I believe it's ok from sig-scheduling side.

yeah, I will reach out, if there are any changes in future, Thank you for taking a look.

[Karthik-K-N]

Based on the conversation over slack and here, Added a section about compatability with Cluster Autoscaler: https://github.com/Karthik-K-N/enhancements/tree/node-resize/keps/sig-node/3953-node-resource-hot-plug#compatability-with-cluster-autoscaler.
Please take a look. Thanks.

Thank you, the added section accurately captures the problem and possible solutions. Could you add some information on when you want to address this part? When going to beta with the feature?

Thanks for the review, We plan to provide compatibility with autoscaler by storing the initial node resource in node object and also plan to provide this feature during beta graduation so we can get started now. But we are open for community feedback. Thank you.

[towca]

Thanks for the review, We plan to provide compatibility with autoscaler by storing the initial node resource in node object and also plan to provide this feature during beta graduation so we can get started now. But we are open for community feedback. Thank you.

Sounds good to me, thanks!

[elmiko]

gave a read of the kep, no comments or suggestions currently, but happy to see this work progressing.

[kannon92]

I don't really see you call out devices. Is this in scope for this feature? ie adding gpudevices?

[Karthik-K-N]

No its not in the scope, May be I can explicitly mention that for more clarity, Thanks.

[zvonkok]

AFAIU this is only for CPU and Memory what about hot-plug of PCIe devices? How will this work once we have cAdvisorless metrics? #2371

[Karthik-K-N]

AFAIU this is only for CPU and Memory what about hot-plug of PCIe devices? How will this work once we have cAdvisorless metrics? #2371

Yes correct, PCIe devices are out of scope for this KEP, About cAdvisorless metrics would seek help from @haircommander.

[haircommander]

node level metrics aren't covered by 2371 so we should be good there, but regardless of the source if we're going through the stats manager then there should be no difference