Skip to content

KEP-1326: update KEP and mark implemented #5245

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lmktfy
Copy link

@lmktfy lmktfy commented Apr 15, 2025

  • One-line PR description: Update KEP and mark as implemented

Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lmktfy
Once this PR has been reviewed and has the lgtm label, please assign jeremyrickard for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @lmktfy!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @lmktfy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2025
@sftim
Copy link

sftim commented Apr 15, 2025

/ok-to-test
(if I do say so myself)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2025
Comment on lines 14 to 16
- "@cblecker"
- "@derekwaynecarr"
- "@dims"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are from Steering, and the policy itself has already been approved (and implemented).

Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmktfy could you add the appropriate reviewers/approvers for this?

@kikisdeliveryservice kikisdeliveryservice added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 23, 2025
1. Who decides when to include third-party content?
* formally document a consensus on what types of third-party
content are appropriate for inclusion in Kubernetes documentation
* define consistent policies for how Kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit.

We should consider explicitly stating that the scope of the policies mentioned in this point and the standards in the point below are specific to SIG Docs and the content it is responsible for. It might be implied, but I'd like to leave no room for misinterpretation later on.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

Copy link
Author

@lmktfy lmktfy May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eesh. I don't want one policy that applies to content SIG Docs manages and a different policy for other documentation that is also from the Kubernetes project.

I want Kubernetes, the project, to follow one policy about third party content. Is that harmful if we do that? I am happy to get steering to endorse a project-wide policy.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To settle this, we should find people willing to reach out to other SIGs and let them know about this policy, and that we are planning to formally say that this applies across the Kubernetes project.

My reading of the KEP is that it already does, but we didn't staff a big effort to communicate the policy change. It may surprise people if we don't communicate it.

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit, but otherwise LGTM.

@lmktfy lmktfy force-pushed the 20240324_update_sig_docs_kep branch from e98137f to 211f546 Compare May 22, 2025 22:50
@lmktfy
Copy link
Author

lmktfy commented Jun 22, 2025

Actually, this is just a cleanup.

/assign @johnbelamaric

Wrong KEP

@lmktfy
Copy link
Author

lmktfy commented Jun 22, 2025

/unassign @johnbelamaric

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants